Tap To Place Bug?

AWarren

Hi everyone. Im running into issues with TapToPlace that I cant seem to figure out.

I attach TapToPlace from the HoloToolkit on my object. When I launch in the emulator everything works as expected. When I launch to the device after placing and moving a couple of times all code after SpatialMappingManager.Instance.DrawVisualMeshes = true; no longer runs. Here is some code I was testing with. Im changing the color of the cube I am using to move things around to see what is happening. The first few times the cube goes back and forth between blue and red as expected but after about the third time the cube goes black and never gets to blue. The Spatial Mapping Manager draws meshes as expected. Am I missing something?

// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See LICENSE in the project root for license information.

using UnityEngine;

namespace HoloToolkit.Unity
{
///

/// The TapToPlace class is a basic way to enable users to move objects /// and place them on real world surfaces. /// Put this script on the object you want to be able to move. /// Users will be able to tap objects, gaze elsewhere, and perform the /// tap gesture again to place. /// This script is used in conjunction with GazeManager, GestureManager, /// and SpatialMappingManager. ///

/// 


public partial class TapToPlace : MonoBehaviour
{
    bool placing = false;
    public GameObject myItem;
    public GameObject myAudio;


    // Called by GazeGestureManager when the user performs a tap gesture.
    void OnSelect()
    {
        if (SpatialMappingManager.Instance != null)
        {
            // On each tap gesture, toggle whether the user is in placing mode.
            placing = !placing;

            // If the user is in placing mode, display the spatial mapping mesh.
            if (placing)
            {
                gameObject.GetComponent<Renderer>().material.color = Color.black;
                SpatialMappingManager.Instance.DrawVisualMeshes = true;
                gameObject.GetComponent<Renderer>().material.color = Color.blue;


            }
            // If the user is not in placing mode, hide the spatial mapping mesh.
            else
            {
                SpatialMappingManager.Instance.DrawVisualMeshes = false;
                gameObject.GetComponent<Renderer>().material.color = Color.red;

            }
        }
        else
        {
            Debug.Log("TapToPlace requires spatial mapping.  Try adding SpatialMapping prefab to project.");
        }
    }

    // Update is called once per frame.
    void Update()
    {

            // If the user is in placing mode,
            // update the placement to match the user's gaze.
            if (placing)
        {
            // Do a raycast into the world that will only hit the Spatial Mapping mesh.
            var headPosition = Camera.main.transform.position;
            var gazeDirection = Camera.main.transform.forward;

            RaycastHit hitInfo;
            if (Physics.Raycast(headPosition, gazeDirection, out hitInfo,
                30.0f, SpatialMappingManager.Instance.LayerMask))
            {
                // Move this object to where the raycast
                // hit the Spatial Mapping mesh.
                // Here is where you might consider adding intelligence
                // to how the object is placed.  For example, consider
                // placing based on the bottom of the object's
                // collider so it sits properly on surfaces.
                this.transform.position = hitInfo.point;

                // Rotate this object to face the user.
                Quaternion toQuat = Camera.main.transform.localRotation;
                toQuat.x = 0;
                toQuat.z = 0;
                this.transform.rotation = toQuat;
            }
        }
    }
}

}

Patrick

@AWarren,

Yes, I believe there is a bug. I just pushed what I think is the fix. The DrawVisualMeshes property had the potential to access a renderer that had been deleted.

Can you either pull or update UpdateRendering in SpatialMappingManager.cs with:

private void UpdateRendering(bool Enable)
        {
            List<MeshRenderer> renderers = Source.GetMeshRenderers();
            for (int index = 0; index < renderers.Count; index++)
            {
                if (renderers[index] != null)
                {
                    renderers[index].enabled = Enable;
                    if (Enable)
                    {
                        renderers[index].sharedMaterial = SurfaceMaterial;
                    }
                }
            }
        }

Patrick

@AWarren,

Yes, I believe there is a bug. I just pushed what I think is the fix. The DrawVisualMeshes property had the potential to access a renderer that had been deleted.

Can you either pull or update UpdateRendering in SpatialMappingManager.cs with:

private void UpdateRendering(bool Enable)
        {
            List<MeshRenderer> renderers = Source.GetMeshRenderers();
            for (int index = 0; index < renderers.Count; index++)
            {
                if (renderers[index] != null)
                {
                    renderers[index].enabled = Enable;
                    if (Enable)
                    {
                        renderers[index].sharedMaterial = SurfaceMaterial;
                    }
                }
            }
        }

AWarren

That did the trick! Thanks so much!

Patrick

Thanks for reporting the issue.